Skip to content
This repository was archived by the owner on Feb 6, 2019. It is now read-only.

Cleanup a whole load of stuff #1

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Cleanup a whole load of stuff #1

wants to merge 38 commits into from

Conversation

gsnedders
Copy link
Owner

@gsnedders gsnedders commented May 2, 2016 •
edited
Loading

Should summarise significant changes somewhere…

gsnedders added 13 commits May 2, 2016 22:05
@gsnedders
Remove usage of the discouraged intern function.
a89b5de
@gsnedders
Start to move towards PEP8.
b0ebc2e
@gsnedders
Fix flake8 flakes.
04dd046
@gsnedders
Get rid of deprecated has_key
8007dc1
@gsnedders
More PEP8 cleanup
afb0700
@gsnedders
Break up where we have multiple statements on one line
388aabb
@gsnedders
Move all comparisons with None to use "is"
cf0a86e
@gsnedders
Get rid of calls to type()
a423e67 
The change in Indexer.py is a best guess of what is intended!
@gsnedders
Split Sources.py up into smaller files.
221795c
@gsnedders
Let's turn this into a real package :o!
c6e4f70
@gsnedders
Make sure we close all files we open.
1121e31
@gsnedders
Largely rewrite SourceTree.py to make easier to understand
e32308a 
There's a few minor behaviour changes: paths aren't compared with
the various patterns case-insensitively now (this effects nothing
in csswg-test), and the exact syntax of reftest filenames has
changed (this fixes mediaqueries-3/ref.html so that it is picked
up as a reference).

This keeps the existing SourceTree class API for the moment. We
should probably eventually drop it, as it really doesn't make
sense for it to be a class.
@gsnedders
Move SourceTree.py after it's major changes over to PEP8 spacing
a9dc57d
@gsnedders
Copy link
Owner Author

This seems to currently change the encoding of a fair number of files. I have no idea why, currently.

@gsnedders
Copy link
Owner Author

Seems like 1fdfc03 changed encoding behaviour. I don't actually know what use of html5lib's internal APIs like the code used to do actually does…

@gsnedders
Copy link
Owner Author

8050c96 fixes that to correctly set source.encoding, and 376c750 tests that.

@gsnedders
Copy link
Owner Author

We're still dropping BOMs which we seem to not have done previously, which will break some tests.

@gsnedders
Copy link
Owner Author

Though dropping UTF-8 BOMs doesn't matter because .htaccess declares it to be UTF-8 already…

@gsnedders
Copy link
Owner Author

@Ms2ger do you wanna have a look over this before I try and get this all landed? this should be pure cleanup of the code, and no significant behavioural changes (the only significant change is the fact that a Suite now has only one Group in it).

@gsnedders
Copy link
Owner Author

gsnedders commented May 3, 2016 •
edited
Loading

More breakage:

--- dist.old/css-variables-1_dev/html/variable-declaration-42.htm       2016-05-02 20:48:10.000000000 +0200
+++ dist/css-variables-1_dev/html/variable-declaration-42.htm   2016-05-02 23:59:58.000000000 +0200
@@ -13,8 +13,8 @@

Doesn't appear to be output as UTF-8 any more. Hmm.

Similar: dist/css-backgrounds-3_dev/html4/origin-padding-box_with_position.htm

@gsnedders
Copy link
Owner Author

These both have <meta charset=utf8> outwith the first 512 bytes.

@gsnedders
Copy link
Owner Author

Hmm, html spec nowadays does 500ms or 1024 bytes. Wonder when that changed?

@gsnedders
Copy link
Owner Author

So this PR depends on html5lib/html5lib-python#238.

@gsnedders
Copy link
Owner Author

Except that can't be, because it shouldn't have any real observable effect. Hmmm.

@gsnedders
Copy link
Owner Author

html5lib/html5lib-python#241 is it.

gsnedders and others added 22 commits July 15, 2016 02:53
@gsnedders
Fix file paths for catalog/templates
936250f
@gsnedders
Rewrite NamedDict to use collections.MutableMapping
a66ff5d
@gsnedders
Add setup.cfg with some PEP8 config
573b6ae
@gsnedders
Use recommended html5lib API for parsing
cc1bf2c
@gsnedders
Remove unused code
3fddc68
@gsnedders
Make SourceCache normalize the paths in its cache.
773d06e 
In addition, consider the relpath when caching, as we can't
guarantee its identity because it will vary for references.
@gsnedders
Drop support for multiple groups.
7d08f19
@gsnedders
Provide a variable for the repo_root instead of assuming cwd
96d3347
@gsnedders
Remove unspecified license code that's nowadays unneeded.
ed08304
@gsnedders
Add comments documenting which APIs are used
0fe7907 
Because then we can break everything else. Yay!
@gsnedders
Remove old reftest manifest support
2665e7e
@gsnedders
Silence a few more pep8 rules, increase line length to fit all
de7a8dc
@gsnedders
PEP8ify everything. Modulo what the rules we ignore.
794e293
@gsnedders
Remove unused imports
3eb247f
@gsnedders
Duplicate this for flake8 :(
9391e96
@gsnedders
Make everything outside of the package clean with flake8
ec46d80
@gsnedders
Start some sort of testsuite.
06b89c7
@gsnedders
Add a tox.ini
0cac990
@gsnedders
Add a test for SourceCache's caching behaviour around relpaths
7f7572d
@gsnedders
Start testing on Travis CI
66af89e
@gsnedders
Add a bunch of tests for HTML encoding detection
389f1aa
@gsnedders
Add a test for distant meta prescan
b6e3d2d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gsnedders