Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture viewer with overlay #54

Closed
gsantner opened this issue Oct 3, 2017 · 9 comments
Closed

Picture viewer with overlay #54

gsantner opened this issue Oct 3, 2017 · 9 comments

Comments

@gsantner
Copy link
Owner

gsantner commented Oct 3, 2017

The target is to move the main code of the ImageViewActivity to an fragment and use an overlay for the toolbar of the viewed the picture. Toggle toolbar visibility on click on image. See example below.

If you want you can also implement swipe, so the next/previous picture in the list gets displayed on left/right swipe. Attention: The ImageView supports zoom controls, they need to keep working if you add this too

Current Example solution
@gsantner
Copy link
Owner Author

gsantner commented Oct 3, 2017

If you need more information ask. This issue is an idea, and about people to start contributing to the project. It has not much information because I pasted many ideas/issues and just let them out at the same time :). If you are interested in working on this, and have questions I can give you more details on this.

Register on https://hacktoberfest.digitalocean.com/, send a PR to fix this and get your t-shirt for free (4 accepted PRs to same or different GitHub repositories needed) :). You have to mention the issue number in the commit/PR (e.g. fix #20 / about #8) Find more hacktober issues from my projects: https://github.com/search?&q=label%3Ahacktoberfest+user%3Agsantner

@Avjeet
Copy link
Contributor

Avjeet commented Oct 6, 2017

Do we have to put the toolbar in fragment itself?

@gsantner
Copy link
Owner Author

gsantner commented Oct 6, 2017

up to you, do what you think fits best

@Avjeet
Copy link
Contributor

Avjeet commented Oct 6, 2017

then why do u need to transfer the code to a fragment?

@Avjeet
Copy link
Contributor

Avjeet commented Oct 6, 2017

should I just make the overlay transparent.

@gsantner
Copy link
Owner Author

gsantner commented Oct 6, 2017

and the picture behind the toolbar. Why? Because this may be reused later, when pressing a meme-template on the overview - where then preview of the image is shown.

@Avjeet
Copy link
Contributor

Avjeet commented Oct 6, 2017

OK I will work on it.

@gsantner
Copy link
Owner Author

gsantner commented Oct 6, 2017

thanks for your much work. BTW: You can add yourself to the CONTRIBUTORS list if you want

@gsantner
Copy link
Owner Author

Closed as implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants