Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Quick filter all files #2521

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

WIP: Quick filter all files #2521

wants to merge 75 commits into from

Conversation

harshad1
Copy link
Collaborator

@harshad1 harshad1 commented Feb 6, 2025 •
edited
Loading

This PR adds 2 new features:

  1. a quick filter - search for all files in the notebook by tapping on the title.
  2. Share files into markor to attach them to documents. From download folder for example. Files will be copied into notebook like the usual file attachment system

Also included are a ton of fixes and improvements:

  • File browser sorting and loading (especially special folders)
  • Improved delete dialog
  • Speed improvements (2-3x) for the search (on my device at least)
  • undo / redo will track file load

harshad1 and others added 30 commits January 2, 2025 22:26
@harshad1
Initial system with janky ui
34f98b9
@harshad1
Merge remote-tracking branch 'upstream/master' into per_folder_sort_o…
54ba2a6 
…rder
@harshad1
Separate options - aborting
a02026d
@harshad1
Switching to dialog
6f79ce0
@harshad1
Switching to dialog based sort
20b7c5e
@harshad1
Cleanups to dialog
5a01163
@harshad1
New approach to dialog using change callback
2f6cfcb
@harshad1
Must check in the callback :)
342d83a
@harshad1
Fixes, wrap improvements
3237d18
@harshad1
Reverted reflow settings
b4d1d1a
@harshad1
Fixed diff
b35b3d5
@harshad1
Better icon
2f6c5c1
@harshad1
Getting it to work
22c75b2
@harshad1
Invisible instead of gone
099096d
@harshad1
Fixes
980cab9
@gsantner
Merge branch 'master' into per_folder_sort_order
ebb636c
@harshad1
tweaks
fbf07bd
@harshad1
Fixed states
13cbc3f
@harshad1
Merge branch 'per_folder_sort_order' of github.com:harshad1/markor in…
1f82aed 
…to per_folder_sort_order
@harshad1
Merge remote-tracking branch 'upstream/master' into faster_direct_vie…
cd01ca0 
…w_mode
@harshad1
Tweak to wrap state
33bb3ae
@harshad1
Fixed scroll to cursor
e7d4344
@harshad1
File search perf and all files
745de0f
@harshad1
Window options
d418b94
@harshad1
Fixes, using compat
7af05c7
@harshad1
Pulling file search changes
29b672c
@harshad1
Fixing calling and references
b99822e
@harshad1
Maintianing state
c7d0d7e
@harshad1
Reverted changes to file search
3b4dbcf
@harshad1
Fix for jumping to position
7298ea7
@harshad1 harshad1 mentioned this pull request Mar 6, 2025
Open
4 tasks
@gsantner
Copy link
Owner

Unfortunate got lots of conflicts by merging the other PR

@gsantner gsantner linked an issue Mar 11, 2025 that may be closed by this pull request
[View Mode]: Back button doesn't return to editor #2530
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[View Mode]: Back button doesn't return to editor
2 participants
@harshad1 @gsantner