Reference image tool #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference mode
michael-lazar
commented
Jan 21, 2025
| if (o >= a) o = o - a; | ||
| } else if (event.deltaY < 5) { | ||
| if (o <= (1.0 - a)) o = o + a; | ||
| if (event.deltaX > 0 || event.deltaY > 0) { |
Collaborator
Author
There was a problem hiding this comment.
This is one part where I didn't understand the existing code, or why the magic number "5" was chosen for the cutoff in positive/negative scrolling?
At least on my system (macbook air m1 + razer deathaddr v2 mouse):
- Scrolling down is registered as
deltaX = 4.0 - Scrolling up is registered as
deltaX = -4.0 - Holding down the shift key changes the delta on scrolling from
deltaXtodeltaY - Using the touchpad to pinch-to-zoom gives me either positive or negative values centered around
0.
So scrolling was pretty much broken & glitchy for me without making these changes (I could zoom in but I couldn't zoom out).
Owner
There was a problem hiding this comment.
I'm not sure on the magic number either. maybe a resolution thing? some kind of threshold boundary that is crossed? maybe it was too sensitive? hrm.
…g reusable for other messages
Add ability to open reference images in separate windows
Fixes scroll behavior for 200% zoom.
Add outline/border to brush tool.
… recently clicked
Fix for mouse move events
Owner
|
@michael-lazar I completely didn't realize you were doing this! I'll integrate if possible and i can grok your PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tool to the sidebar ("reference tool") that can be used to resize/orient the reference watermark image
I hooked everything up to work with the existing hotkeys and menu options. So for example, if you change opacity with the scroll wheel shortcut, it should reflect appropriately in the UI.
My first idea was to add draggable anchors at the corners of the reference image to allow dragging to resize/rotate the image, as commonly used in image editors. But this was a bit too complicated for me to implement in vanilla JS so I settled on putting the controls in the toolbar instead. The values are standard boxes so you can click in them to type in an exact value, or use the scroll wheel inside the input box to quickly increment/decrement the value.
demo.webm