Skip to content

Add --ext option #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add --ext option #12

wants to merge 8 commits into from

Conversation

vecchp
Copy link

@vecchp vecchp commented May 17, 2019

This PR adds the ability to pass which file extensions lint-diff looks for (since right now we only do .js).

  • Also update peerDependency for eslint to be >=4.x
  • Upgrade ramda to 0.26.1
  • Replace pipeP with pipeWith as pipeP is deprecated.

@vecchp
Copy link
Author

vecchp commented May 20, 2019

@grvcoelho ,This should be ready for review.

@shoesel
Copy link

shoesel commented May 24, 2019

yes, pls

@vecchp
Copy link
Author

vecchp commented May 24, 2019

@shoesel , I made a release based off this PR in the interim if you want to use it. https://github.com/vecchp/lint-diff/releases/download/v1.3.0/lint-diff-1.3.0.tgz

@vecchp
Copy link
Author

vecchp commented May 31, 2019

@grvcoelho is this project still maintained?

@vecchp
Copy link
Author

vecchp commented Jul 3, 2019

@grvcoelho , any chance you'd be able to review this PR?

@joker-777
Copy link

This feature would be awesome!

@joker-777
Copy link

@vecchp It looks like this project isn't maintained anymore. Could you publish your version to npm?

@vecchp
Copy link
Author

vecchp commented Sep 8, 2019

Sure, I'll try and get around to that this evening

@vecchp
Copy link
Author

vecchp commented Sep 9, 2019

I didn't have a chance last night but I'll make my best effort to publish it soon.

@vecchp
Copy link
Author

vecchp commented Sep 23, 2019

Should be published as @vecchp/lint-diff@1.3.0 now

@vecchp
Copy link
Author

vecchp commented Apr 3, 2021

We are considering moving to this plugin in favor of lint-diff: https://github.com/paleite/eslint-plugin-diff

@vecchp vecchp closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants