-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: Documenting support for --filter in the run command
#5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Documenting support for --filter in the run command
#5015
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughDocumentation updates across multiple files to reflect that the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
be18b91 to
1a43f7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs-starlight/src/data/commands/run.mdx (1)
112-112: Path format should be consistent with feature documentation.Line 112 shows
'prod/**'without the leading./prefix, but the filter feature documentation indocs-starlight/src/content/docs/03-features/18-filter.mdxconsistently uses'./envs/prod/**'for relative paths (see lines 108-109). For consistency across documentation, update this example to use the./prefix:- terragrunt run --all --filter 'prod/**' -- plan + terragrunt run --all --filter './prod/**' -- plan
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs-starlight/src/content/docs/03-features/18-filter.mdx(2 hunks)docs-starlight/src/content/docs/04-reference/04-experiments.md(2 hunks)docs-starlight/src/data/commands/run.mdx(2 hunks)docs-starlight/src/data/flags/filter.mdx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs-starlight/**/*.md*
⚙️ CodeRabbit configuration file
Review the documentation for clarity, grammar, and spelling. Make sure that the documentation is easy to understand and follow. There is currently a migration underway from the Jekyll based documentation in
docsto the Starlight + Astro based documentation indocs-starlight. Make sure that thedocs-starlightdocumentation is accurate and up-to-date with thedocsdocumentation, and that any difference between them results in an improvement in thedocs-starlightdocumentation.
Files:
docs-starlight/src/data/commands/run.mdxdocs-starlight/src/content/docs/03-features/18-filter.mdxdocs-starlight/src/content/docs/04-reference/04-experiments.mddocs-starlight/src/data/flags/filter.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: license_check / License Check
- GitHub Check: Pull Request has non-contributor approval
- GitHub Check: build-and-test
🔇 Additional comments (4)
docs-starlight/src/content/docs/03-features/18-filter.mdx (1)
23-23: Updates are consistent with feature completion.The changes correctly reflect that
--filteris now available in theruncommand alongsidefindandlist. The updates maintain consistency with the status changes in other files.Also applies to: 320-320
docs-starlight/src/data/flags/filter.mdx (1)
20-20: Updates accurately reflect filter support in run command.The documentation correctly indicates that
--filteris now available in theruncommand, and the usage example appropriately shows--all --filtertogether, which is the correct pattern for filtering across multiple units.Also applies to: 116-116
docs-starlight/src/data/commands/run.mdx (1)
94-143: New filtering section is well-structured and comprehensive.The "Filtering Units" section provides clear progression from basic to advanced examples, the experimental feature notice is properly formatted, and the "Learn More" tip appropriately directs users to comprehensive filter documentation. The examples correctly show that
--allis used together with--filterin theruncommand context.docs-starlight/src/content/docs/04-reference/04-experiments.md (1)
131-131: Experiment status correctly reflects run command integration completion.The updates to the
filter-flagexperiment status accurately reflect that theruncommand integration is now complete and available (marked with ✅ and [x]). The expanded "Not Yet Implemented" section appropriately outlines the remaining work items for stabilizing the filter-flag feature.Also applies to: 166-166
Description
Documents support for the
--filterflag in theruncommand.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added docs for
--filtersupport inrun.Migration Guide
Summary by CodeRabbit
--filterflag support in theruncommand (now available in find, list, and run).runcommand.runcommand as completed.