This repository was archived by the owner on Mar 29, 2023. It is now read-only.
Upgrade to Terraform 0.12 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
reviewed
Jun 25, 2019
Contributor
yorinasub17
left a comment
yorinasub17
left a comment
There was a problem hiding this comment.
LGTM! Left some minor suggestions for improving the types.
| variable "database_flags" { | ||
| description = "List of Cloud SQL flags that are applied to the database server" | ||
| type = "list" | ||
| type = list(any) |
Contributor
There was a problem hiding this comment.
Do you know if both name and value are required? If so, maybe switch to:
Suggested change
| type = list(any) | |
| type = list(object({name = string, value = string})) |
Contributor
Author
There was a problem hiding this comment.
@yorinasub17 they are both optional, but it's pointless to pass anything else or only pass one of them, should I make that change anyway?
Contributor
Author
There was a problem hiding this comment.
I guess the value would need to be any as you can pass integers and strings etc: https://cloud.google.com/sql/docs/mysql/flags
Contributor
Author
Contributor
Author
|
I'm going to go ahead and release this. There's one minor open question about improving the types, but we can ship it in a patch release. cc @yorinasub17 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
terraform-google-sqlto use Terraform 0.12. This is a backwards incompatible change.