Skip to content
This repository was archived by the owner on Mar 29, 2023. It is now read-only.

Conversation

@autero1
Copy link
Contributor

@autero1 autero1 commented May 9, 2019

No description provided.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few more missing links.

<!-- NOTE: We use absolute linking here instead of relative linking, because the terraform registry does not support
relative linking correctly.
-->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed links:

  • cloud-sql module reference in the section listing out the "primary modules"
  • Gruntwork Philosophy link
  • Contribution Guidelines link
  • LICENSE link
  • Releases link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, love the IDEs... I seemed to have some magical IntelliJ filter in my link search. Will fix!

<!-- NOTE: We use absolute linking here instead of relative linking, because the terraform registry does not support
relative linking correctly.
-->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed links:

  • examples folder link
  • variables.tf link
  • outputs.tf link

@autero1 autero1 requested a review from yorinasub17 May 9, 2019 17:27
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@autero1 autero1 merged commit 400d8b6 into master May 9, 2019
@autero1 autero1 deleted the fix_links branch May 9, 2019 17:30
@autero1 autero1 changed the title [skip ci] Fix links Fix links May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants