Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Variable enable_legacy_abac isn't work #79

Closed
vscoder opened this issue Jan 11, 2020 · 1 comment
Closed

Variable enable_legacy_abac isn't work #79

vscoder opened this issue Jan 11, 2020 · 1 comment

Comments

@vscoder
Copy link
Contributor

vscoder commented Jan 11, 2020

How to reproduce

In module gke-cluster is defined variable

variable "enable_legacy_abac" {
description = "Whether to enable legacy Attribute-Based Access Control (ABAC). RBAC has significant security advantages over ABAC."
type = bool
default = false
}

I set value for this variable to true

module "gke_cluster" {
  ...
  enable_legacy_abac = "true"
}

Expected behaviour

When i do terraform apply, i expect to see:

  # module.gke_cluster.google_container_cluster.cluster will be created
  + resource "google_container_cluster" "cluster" {
      ...
      + enable_legacy_abac          = true

Real behavior

When i do terraform apply, i see:

  # module.gke_cluster.google_container_cluster.cluster will be created
  + resource "google_container_cluster" "cluster" {
      ...
      + enable_legacy_abac          = false

How to fix

In file modules/gke-cluster/main.tf block resource "google_container_cluster" "cluster" {...} add

resource "google_container_cluster" "cluster" {
  enable_legacy_abac = var.enable_legacy_abac
  ...
}
vscoder added a commit to vscoder/terraform-google-gke that referenced this issue Jan 12, 2020
vscoder added a commit to vscoder/terraform-google-gke that referenced this issue Mar 25, 2020
yorinasub17 added a commit that referenced this issue Mar 25, 2020
@robmorgan
Copy link
Contributor

Fixed in #80

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants