Skip to content

Fix telemetry error #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2023
Merged

Fix telemetry error #88

merged 4 commits into from
Apr 20, 2023

Conversation

ellisonc
Copy link

Description

Doesn't kill the process when telemetry encounters an error

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

oredavids
oredavids approved these changes Apr 20, 2023
View reviewed changes
Copy link

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed live.

@ellisonc ellisonc merged commit 9517ad3 into master Apr 20, 2023
@ellisonc ellisonc deleted the fix-telemetry-error branch April 20, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oredavids oredavids oredavids approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98

@arsci arsci Awaiting requested review from arsci arsci is a code owner

@zackproser zackproser Awaiting requested review from zackproser

@pete0emerson pete0emerson Awaiting requested review from pete0emerson

@james03160927 james03160927 Awaiting requested review from james03160927

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellisonc @oredavids