Skip to content

Add function to convert key=value slice pairs to map #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

yorinasub17
Copy link
Contributor

This adds a new function that helps with converting a key=value slice of strings to a map. This is useful for working with the return value of os.Environ().

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

  • Added a new function collections.KeyValueStringSliceAsMap which can be used to work with a slice of key=value pairs.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner July 26, 2022 20:24
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging in now.

@yorinasub17 yorinasub17 merged commit 2689f46 into master Jul 27, 2022
@yorinasub17 yorinasub17 deleted the feature/function-to-convert-slice branch July 27, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants