-
Notifications
You must be signed in to change notification settings - Fork 26
Bump urfave/cli to v2 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of updating, but there are quite a few backwards incompatible changes: https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md. That means that the next time we update any of our CLI apps tot he latest version of gruntwork-cil
, we'll have to change a good amount of code and some aspects of the CLI UX will change too (e.g., args vs options order). Is that worth taking on right now?
18df06a
to
978768f
Compare
We don't really have to take on migrating right now (after all, we could just hold the version back in each respective CLI). I thought it would be nice to do this though so that new CLIs will be on the v2 version. |
I believe most of our commands/CLI that we have that use this will not be sensitive to this. But I could be wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave this one up to you Yori. If this is not likely to be a painful / yak shave upgrade, then let's stay up to date. If this looks like a lot of potential churn, then perhaps we punt until later.
@yorinasub17 what do you feel your next step will be? I'm on the fence of using entrypoint for my own Terraform CLI wrapper as it is still using urfave/cli/v1 as opposed to v2. E: Using this branch
|
978768f
to
05d1f96
Compare
UPDATE: rebased on |
We are looking to upgrade the Patcher CLI to |
05d1f96
to
1602069
Compare
Just rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for review! Merging now. |
This bumps
urfave/cli
to v2 track. This is an opportunistic upgrade (we're not using any of the features yet) so that we can stay up to date as bugs are fixed.