Skip to content

Bump urfave/cli to v2 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Bump urfave/cli to v2 #33

merged 1 commit into from
Feb 28, 2022

Conversation

yorinasub17
Copy link
Contributor

This bumps urfave/cli to v2 track. This is an opportunistic upgrade (we're not using any of the features yet) so that we can stay up to date as bugs are fixed.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner August 29, 2020 15:37
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of updating, but there are quite a few backwards incompatible changes: https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md. That means that the next time we update any of our CLI apps tot he latest version of gruntwork-cil, we'll have to change a good amount of code and some aspects of the CLI UX will change too (e.g., args vs options order). Is that worth taking on right now?

@gruntwork-io gruntwork-io deleted a comment from brikis98 Aug 31, 2020
@yorinasub17
Copy link
Contributor Author

yorinasub17 commented Aug 31, 2020

Is that worth taking on right now?

We don't really have to take on migrating right now (after all, we could just hold the version back in each respective CLI). I thought it would be nice to do this though so that new CLIs will be on the v2 version.

@yorinasub17
Copy link
Contributor Author

args vs options order

I believe most of our commands/CLI that we have that use this will not be sensitive to this. But I could be wrong.

brikis98
brikis98 previously approved these changes Sep 1, 2020
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave this one up to you Yori. If this is not likely to be a painful / yak shave upgrade, then let's stay up to date. If this looks like a lot of potential churn, then perhaps we punt until later.

@osulli
Copy link

osulli commented Oct 28, 2020

@yorinasub17 what do you feel your next step will be?

I'm on the fence of using entrypoint for my own Terraform CLI wrapper as it is still using urfave/cli/v1 as opposed to v2.

E: Using this branch

# go.mod
require (
	github.com/gruntwork-io/gruntwork-cli v0.7.1-0.20200831164626-978768fef544 // https://github.com/gruntwork-io/gruntwork-cli/pull/33
)

@yorinasub17
Copy link
Contributor Author

UPDATE: rebased on master.

@infraredgirl
Copy link
Contributor

We are looking to upgrade the Patcher CLI to v2 of urfave/cli, and it seems this PR needs to get merged first. @yorinasub17 can I help push this over the line? Is only rebasing and fixing conflicts needed or something else as well? Happy to take over this PR and shepherd it to completion!

@yorinasub17
Copy link
Contributor Author

Just rebased on master and it looks like build passed and no more merge conflict, so this is ready for merge again! (provided you don't find anything else that needs updating).

Copy link
Contributor

@infraredgirl infraredgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit 75d5cc4 into master Feb 28, 2022
@yorinasub17 yorinasub17 deleted the yori-bump-urfavecli branch February 28, 2022 19:37
@yorinasub17
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants