Add concept of sensitive args #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Nov 28, 2018
shell/cmd_test.go
Outdated
|
|
||
| assert.Nil(t, RunShellCommand(options, "echo", "hi")) | ||
| assert.False(t, strings.Contains(buffer.String(), "hi")) | ||
| assert.True(t, strings.Contains(buffer.String(), "echo")) |
There was a problem hiding this comment.
Use assert.Contains and assert.NotContains
Yea I thought about this, but it was hard to come up with a good API for the general case when the target command could be anything. |
|
Merging and releasing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we log the command string when we call commands using
RunShellCommand, which is really nice for debugging purposes. However, sometimes this should be suppressed because the args might include sensitive data. For example, when scripting calls toopensslto create certs, the password can only be passed in via the command line when avoiding the prompt.The solution proposed and implemented here is to add a new shell option that marks the commands as having sensitive args, which is used to suppress logging the args.