Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI config to sign MacOS binaries #137

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

marinalimeira
Copy link
Contributor

@marinalimeira marinalimeira commented Aug 11, 2023

Description

We are already able to sign the binaries of internal projects, like patcher-cli and terrapatch-cli.

I am replicating the same process in git-xargs, the MacOS binaries will be signed and notarized before generating the sha256sum.

Related:

Test release: https://github.com/gruntwork-io/git-xargs/releases/tag/v0.1.10-test-signing-binaries

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Signing MacOS binaries from now on! 🎉

@marinalimeira
Copy link
Contributor Author

Thanks for reviewing!

@marinalimeira marinalimeira merged commit 3018857 into master Aug 11, 2023
3 checks passed
@marinalimeira marinalimeira deleted the sign-macos-builds branch August 11, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants