fix: re-export CustomValidationRule and expose validation arguments#281
Open
josh-padnick wants to merge 1 commit intomainfrom
Open
fix: re-export CustomValidationRule and expose validation arguments#281josh-padnick wants to merge 1 commit intomainfrom
josh-padnick wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #277, external consumers (e.g., Gruntwork Runbooks) that use boilerplate as a Go library can no longer reference
CustomValidationRuleby name after the move tointernal/. They also lack a way to extract validation arguments (e.g. The1, 3inlength(1, 3)) using the Go interfaces available through boilerplate. These changes restore public API access and provide structured metadata for parameterized validation rules.Details
CustomValidationRulefrom thevariablespackage via a type alias, restoring public access that was lost when feat: Adding WASM build target #277 moved the type tointernal/validationArgsfield toCustomValidationRuleso that parameterized rules (regex,length) expose their arguments programmaticallyTODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
fix: re-export CustomValidationRule and expose validation arguments