Closed
Conversation
|
@jlambert121 is attempting to deploy a commit to the Gruntwork Team on Vercel. A member of the Team first needs to authorize it. |
jlambert121
commented
Feb 14, 2026
| Logger.Printf("Running command: %s %s", command, strings.Join(args, " ")) | ||
| // Run the given shell command with the given environment variables and arguments in the given working directory | ||
| func RunShellCommandAndGetOutput(workingDir string, envVars []string, command string, args ...string) (string, error) { | ||
| fmt.Printf("Running command: %s %s\n", command, strings.Join(args, " ")) |
Author
There was a problem hiding this comment.
Not using slog, but seems like maybe it is OK for these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82.
Currently all logging is done via utils.Logger which just outputs logging to stdout. It would be nice to have more control over logging by silencing logging when not needed or injecting a separate logger (compatible with *slog.Logger).
There is a lot of lines of change here, but it's just creating a slog.Handler that prefixes [boilerplate] to log lines to maintain the existing look and passing an instance of the logger throughout. go is not my primary language though, any feedback is greatly appreciated!
Replaces #189