Skip to content

fix documentation discrepancy with IMDS version #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix documentation discrepancy with IMDS version #55

merged 1 commit into from
Nov 15, 2023

Conversation

gcagle3
Copy link
Contributor

@gcagle3 gcagle3 commented Nov 3, 2023

Description

Fixes #54. Update code comment documentation to reflect the correct environment vars needed to set the IMDS version.

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

@gcagle3 gcagle3 requested a review from brikis98 as a code owner November 3, 2023 21:12
@arsci arsci merged commit 59cbcbc into gruntwork-io:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsci arsci arsci approved these changes

@denis256 denis256 denis256 approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation discrepancy with IMDS Version
3 participants
@gcagle3 @arsci @denis256