Added new dynamic-ubuntu-wait.sh

[eak12913]

A utility script that can be curled and used in our various packer builds when we construct ubuntu AMIs.

[brikis98]

Code looks great. Now it just needs an example and test :)

[brikis98]

Oh, also, please add it to the root README and show an example one-liner of how it can be used (via curl and |).

[eak12913]

Jim, I've added the example and the call-out in the README but I'm not entirely sure how to test this. The only test I can think of would have to be a go test of building an AMI using two different packer templates. One with the curling of this script and one without. The expectation being that the packer template that doesn't curl this script gets an error while the one that does curl this script gets no error. Is this what you are thinking of?

[brikis98]

A Packer template built on Ubuntu that calls your script first and then apt-get update && apt-get install <something silly>, plus a test case for the same, would prob be enough.

[brikis98]

-LsS. Also, that URL doesn't look quite right... And it should be versioned.

[josh-padnick]

We should come up with an official Gruntwork standard for curl. I actually like to use the fully laid out options of:

curl --location --silent --fail --show-error ...

This will:

• Follow redirects
• Output nothing
• ...unless there's an error
• Return a non-zero exit code if anything other than a 2XX HTTP response code is returned.

The one issue is that sometimes an API will return a 2XX response but along with an error, but I haven't been able to come up with anything better.

[brikis98]

Agreed for scripts, but with the curl | bash one-liner, you typically prefer brevity...

[eak12913]

Jim - is this what you were thinking for the url with version?

curl -LsS https://raw.githubusercontent.com/gruntwork-io/bash-commons/[VERSION]/modules/bash-commons/src/dynamic-ubuntu-wait.sh | bash

[brikis98]

Yup!

[eak12913]

In that case: done :-)

[josh-padnick]

Fair enough on the brevity, but I'm wondering if this should be:

curl -LsSf https://raw.githubusercontent.com/gruntwork-io/bash-commons/[VERSION]/modules/bash-commons/src/dynamic-ubuntu-wait.sh | bash

Try curling a URL that 404s and see if this returns a non-zero exit code (and therefore causes the entire script to exit), which is what we would want for an invalid URL. That's my goal in adding the -f / --fail. Otherwise, I'm worried that the curl call could fail (e.g. for transient reasons) and lead to confusing errors for users.

[brikis98]

Alphabetic order

[eak12913]

done

[brikis98]

Just add an example Packer template that uses this and a test for same, and this is good to go.

[yorinasub17]

I am resurrecting this PR because we are using it in our ELK AMI examples and it feels sketchy to use unreleased code.

I added a go integration test for testing this (f32ccd6), but one problem is that the current circleCI build doesn't have AWS credentials, so it is failing. Is there any risk to adding the credentials?

The other issue I ran into is that the checksums for the shellcheck repo is now broken. Digging in I landed on this issue which suggest that we should be sourcing them from github now, so I fixed the docker container: b6ea582

[brikis98]

Adding AWS creds to this repo is fine.

Apparently, with the new CircleCi, you do that using contexts. I added our machine user data to a context called "Gruntwork Admin," and I think you can use it by adding context: Gruntwork Admin to a job:

workflows:
   my-workflow:
     jobs:
       - run-tests:
           context: Gruntwork Admin

[yorinasub17]

Apparently, with the new CircleCi, you do that using contexts. I added our machine user data to a context called "Gruntwork Admin," and I think you can use it by adding context: Gruntwork Admin to a job:

Thanks! Just added in to see if it works.

[yorinasub17]

I believe I addressed all comments and the test is passing now!

[brikis98]

LGTM!

[yorinasub17]

Thanks for review! Going to merge and release this now.