Addition of function to calculate rally point instance in AWS Auto Scaling Groups #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with running under Python 2.
… allows you to calculate a single 'rally point' instance that is part of an auto-scaling group, useful for executing bootstrapping commands once per ASG.
|
I believe I should split out the unit tests here for the private vs public DNS name usage, but wanted to get this up in the meantime for a review other than that. |
… set, and split out public vs private hostname call scenarios to be consistent with other tests.
|
I split the unit tests out and also refactored the new tests such that the setup code for each set isn't duplicated. The latter isn't the same way other things are done, so if you'd like me to back that out and just have the code in each test let me know. Thanks! |
…ncoding environment variables, which resolves some issues when running tests, as well as removing some un-necessary 'sudo' calls.
…l basic dependencies' section of the test Dockerfiles per comments from maintainer.
…oint' function to ensure that the function fails when the ASG does not contain the requisite number of instances after the given retry / wait period has elapsed.
brikis98
reviewed
Apr 7, 2021
…ments / details around the use of the locale environment variables.
brikis98
approved these changes
Apr 8, 2021
|
Tests passed! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32 as well as updating the Dockerfiles used for testing to use Python 3 (I could not get them to run using the older Python version).