Ensure that stdout/stderr is properly flushed before exiting #382
Conversation
|
Any advice on how to test these changes? Like we saw with your simple test in IRC, the output that you can expect to get isn't really guaranteed or consistent between runs, so I'm not sure how I'd write tests against this that would give reliable/reproducible outcomes for these errors. Current tests pass fully with the exception of 22 tests that you said are currently being worked on in the devel branch. I've built a couple projects locally with this without issues, and I may see about testing this on our CI server as well where this issue was very reproducible. |
| grunt.exit = function(code) { | ||
| // Since exiting in this manner is an asynchronous action, we need to first drain | ||
| // the action queue so that we don't improperly proceed to the next task. | ||
| while(grunt.task._queue.pop()){} |
There was a problem hiding this comment.
You should be able to just call grunt.task.clearQueue() here, see the relevant unit test.
|
It would be SO much easier if this was fixed upstream in Node.js. |
|
I'm going to wait and see if they fix this in nodejs/node-v0.x-archive#3584 |
|
Also, in the short term, this can be worked around by piping grunt output to a temp file, eg: grunt --no-color > %TEMP%\grunt & type %TEMP%\grunt & del %TEMP%\grunt |
In Windows, node currently does not properly flush the stderr/stdout streams before exiting when process.exit() is called. To work around that, we can ensure that those streams have been fully flushed prior to calling process.exit.
Related to one of the issues being discussed in cowboy/grunt#377