Added support for NETSTANDARD 1.0+ and PCL Profile 151 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jchannon can you please test these changes as well :) I have this all working in our app. @grumpydev can we get this merged in :) |
| @@ -4125,7 +4246,7 @@ public static Assembly Assembly(this Type type) | |||
| } | |||
| #endif | |||
| // reverse shim for WinRT SR changes... | |||
| #if (!NETFX_CORE && !NETSTANDARD1_5) | |||
| #if (!NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 || NETSTANDARD1_6) | |||
There was a problem hiding this comment.
Should this be !NETSTANDARD1_6
There was a problem hiding this comment.
Good eye, I've updated this.
|
@grumpydev can we get this merged :) |
|
Do we need all that extra reflection stuff? Also, don't seem to be using the _genericMethodCache - is that intentional (because reflection is cached internally now), or an oversight? |
|
@grumpydev yep it's a polyfil for netstandard 1.0-1.2 which doesn't have some of the types and may never but the functionality is there. It may be nice if 3 months down the road we remove all the compiler directives except net standard: https://oren.codes/2016/06/23/portable-is-dead-long-live-netstandard/ That could be an oversight... I'm not sure I never added that or touched it. |
|
This doesn't build for me... There's two definitions of I assume Even after fixing that, there's still several build errors: Do I need to add any additional references to get it working on .NET Standard 1.6? |
Daniel15
reviewed
Oct 2, 2016
| @@ -4125,7 +4246,7 @@ public static Assembly Assembly(this Type type) | |||
| } | |||
| #endif | |||
| // reverse shim for WinRT SR changes... | |||
| #if (!NETFX_CORE && !NETSTANDARD1_5) | |||
| #if (!NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 || !NETSTANDARD1_6) | |||
There was a problem hiding this comment.
This always evaluates to true, !NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 is true when NETSTANDARD1_6 is defined, and !NETSTANDARD1_6 is true when NETSTANDARD1_6 is not defined, so OR-ing them will always evaluate to true 😕
I think the || is supposed to be &&.
|
Yeah, that should probably be changed to just !NETSTANDARD |
|
Also I worked out that I needed to add a reference to the |
|
The type extensions are only for 1.3 and above. That's why those were on there. |
gkarabin
pushed a commit
to gkarabin/TinyIoC
that referenced
this pull request
Apr 16, 2020
Added support for NETSTANDARD 1.0+ and PCL Profile 151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this on .NET standard profiles 1.0-1.5 as well as PCL Profile 151.
Now you can target .NET standard 1.0 and have the basic functionality but as you up your .net standard you get more functionality :)