Fix invalid transition-property value
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@le717 Thanks! The quoted value works in Chrome (try setting a really long duration), but you're right that the value should not be quoted. Merging. |
gruehle
added a commit
that referenced
this pull request
Jun 3, 2014
Fix invalid `transition-property` value
|
@gruehle That's odd. I had no idea Chrome supported the property in quotes. Chromium 36 was throwing a syntax error on that line and saying it could not run that transition, but I noticed removing the quotes did not make a change: both times the opacity of the button was transitioned. Very interesting. Thanks for the amazing extension, by the way! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for an error that has been present since the CSS was added. :)