Skip to content

A94: OTel metrics for Subchannels #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 12, 2025
Merged

A94: OTel metrics for Subchannels #485

merged 18 commits into from
Aug 12, 2025

Conversation

@yashykt
Copy link
Member

@yashykt yashykt commented Mar 19, 2025 •
edited
Loading

@yashykt yashykt mentioned this pull request Mar 19, 2025
Closed
@yashykt
Copy link
Member Author

yashykt commented Mar 19, 2025

cc @joybestourous

joybestourous
joybestourous reviewed Mar 19, 2025
View reviewed changes
Copy link

@joybestourous joybestourous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for including the open_connection metric, this is super helpful for us.

markdroth
markdroth reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up, Yash!

@yashykt yashykt changed the title A94: gRPC OTel metrics for Subchannels A94: OTel metrics for Subchannels Apr 3, 2025
ejona86
ejona86 reviewed Apr 3, 2025
View reviewed changes
@yashykt yashykt mentioned this pull request Apr 25, 2025
Closed
@dfawley dfawley mentioned this pull request Apr 28, 2025
Closed
markdroth
markdroth reviewed Jun 17, 2025
View reviewed changes
markdroth
markdroth approved these changes Jun 27, 2025
View reviewed changes
dfawley
dfawley approved these changes Jun 30, 2025
View reviewed changes
AgraVator
AgraVator reviewed Jul 9, 2025
View reviewed changes
ejona86
ejona86 reviewed Jul 10, 2025
View reviewed changes
@yashykt yashykt removed the request for review from purnesh42H August 12, 2025 23:00
@yashykt yashykt merged commit 292de67 into grpc:master Aug 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgraVator AgraVator AgraVator left review comments

@ejona86 ejona86 ejona86 approved these changes

@markdroth markdroth markdroth approved these changes

@dfawley dfawley dfawley approved these changes

+1 more reviewer

@joybestourous joybestourous joybestourous left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add connection metrics to standard Otel Stats

6 participants

@yashykt @ejona86 @markdroth @dfawley @joybestourous @AgraVator