-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L108: Node.js Reflection Server Library #397
L108: Node.js Reflection Server Library #397
Conversation
I took the liberty of updating the PR title. The proposal itself is for the "Node.js Reflection Server Library", and the status can be managed within the text of the proposal document. Please list me as the approver, create a discussion thread as described in the README's process section, and update the status in the document to "In Review". In addition, L107 is already reserved for #395, so please update the PR title and text to L108. |
40983fc
to
040c8de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in grpc/grpc-node#79, it should be possible for the Server class to expose all of the necessary information to support reflection. The reflection library should have an API to take advantage of that by making it as simple as possible to add reflection, e.g. it could export a top-level function enableReflection(server)
. This is also important because a server can have services based on proto files that the user does not have direct access to: in grpc-js, the addAdminServicesToServer
adds the channelz service, and also the CSDS service if using xDS.
446124b
to
5547e71
Compare
adding proposal as discussed in grpc/grpc-node#79