Move retry code into its own filter in the DynamicFilter stack#25820
Merged
markdroth merged 10 commits intogrpc:masterfrom Mar 31, 2021
Merged
Move retry code into its own filter in the DynamicFilter stack#25820markdroth merged 10 commits intogrpc:masterfrom
markdroth merged 10 commits intogrpc:masterfrom
Conversation
This was referenced Mar 30, 2021
veblush
approved these changes
Mar 31, 2021
Contributor
veblush
left a comment
There was a problem hiding this comment.
Thank you for the refactoring. I mostly focused on the code structure rather than its implementation, assuming this doesn't change retry logic much.
Member
Author
|
Known issues: #25856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the restructuring of the client channel filter that I mentioned in #25791. The main change is to move the retry code to its own filter in the DynamicFilter stack, but it also moves the definition of the client channel filter's channel data class into the .h file, which makes it easier to interact with it from other places.
Prior to this PR, the final filter in the DynamicFilter stack was always the DynamicTerminationFilter, which would check whether retries were enabled and then create either a LoadBalancedCall or a RetryingCall (which would internally create a LoadBalancedCall for each retry attempt). In other words, the flow was one of these two, depending on whether retries were enabled:
Retries enabled: DynamicFilters -> DynamicTerminationFilter -> RetryingCall -> LoadBalancedCall
Retries disabled: DynamicFilters -> DynamicTerminationFilter -> LoadBalancedCall
This PR moves the RetryingCall code into an alternative version of the DynamicTerminationFilter that performs retries, and the client channel filter decides whether to use the DynamicTerminationFilter or the RetryFilter based on whether retries are enabled. So the flows now look like this:
Retries enabled: DynamicFilters -> RetryFilter -> LoadBalancedCall
Retries disabled: DynamicFilters -> DynamicTerminationFilter -> LoadBalancedCall
Please let me know if you have any questions.