-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificate provider registry implementation #24080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor suggestion. Otherwise, looks great!
Reviewed 20 of 20 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yashykt)
src/core/ext/xds/certificate_provider_registry.cc, line 57 at r1 (raw file):
// hurting performance (which is unlikely, since these allocations // only occur at gRPC initialization time). absl::InlinedVector<std::unique_ptr<CertificateProviderFactory>, 3>
Why not just use std::map<>
here? That would make lookups more efficient at run-time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @markdroth)
src/core/ext/xds/certificate_provider_registry.cc, line 57 at r1 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Why not just use
std::map<>
here? That would make lookups more efficient at run-time.
I don't have data for this, but from sounds like for a small number of elements vectors are faster than std::map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
src/core/ext/xds/certificate_provider_registry.cc, line 57 at r1 (raw file):
Previously, yashykt (Yash Tibrewal) wrote…
I don't have data for this, but from sounds like for a small number of elements vectors are faster than std::map.
A map seems more natural to me, but I guess it doesn't really matter. This is fine for now.
Thanks for reviewing! |
This change is