Allow multiple .on() callbacks and fix issue with non-OK status #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632
Fixes #292
This fixes the issue where calling
.on(<event>, callback)
to set a callback should have added the callback to listen to<event>
, instead of overriding the existing one. This PR also adds a.removeListener(<event>, callback)
method to allow removing a callback.Fixed #786
This fixes the issue where, in unary calls, we should not have sent the data/response back up, if the rpc ended with a non-OK grpc status. See the linked comment from #786 for more details.
This PR also added tests for all the above scenarios.