-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Feature: Add ES6 import style #821
Conversation
@Yannic Thanks for the contributions, as always. There are some build failures. See below. But the bigger issue is that - there is a big change coming from the internal codebase being reviewed at the same time (even coming up the same day!). There was some other issues at hand, which looks like we have to split outputing the normal callback-based client and the Promised-based client into separate files. See #827. So there will be some conflicts around here: https://github.com/grpc/grpc-web/pull/821/files#diff-2e729f9088e537bfeb6fefc318963a96R1392-R1402. I tried to merge these 2 changes as a test but obviously they have conflicts. So my plan is to let the internal change finalized first. And then I will export that out (most likely to merge #827), and then can you rebase on top of that? So this may take a while to develop. I will let you know again in this PR when that's ready. Sorry for the inconvenience. The build failure:
|
Thanks for the update, sounds good. Let me know when the other change landed and I'll rebase and fix this. |
This change adds a new `import_style` that emits ES6 modules. For now, this only re-exports the symbols from `import_style=closure`. In the future, this will no longer require emitting google modules (`goog.provide`). If protobuf ever adds support for emitting ES6 modules, we will use them instead of the `goog.provided`'d versions as well. Note that the Bazel integration is currently broken because of a limitation in `rules_closure`.
@stanley-cheung Thanks, rebased. Fortunately, the merge conflicts turned out to be trivial (both commits inserted a function in the same location). I've also fixed the buildifier warnings. If this will be mentioned in the release notes, please make sure it's marked as experimental and that we reserve the right to do breaking changes. |
This change adds a new
import_style
that emits ES6 modules.For now, this only re-exports the symbols from
import_style=closure
.In the future, this will no longer require emitting google modules
(
goog.provide
). If protobuf ever adds support for emitting ES6modules, we will use them instead of the
goog.provided
'd versionsas well.
Note that the Bazel integration is currently broken because of a
limitation in
rules_closure
.