Fix a bug in test: callback not properly intercepted #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #661
The bug is that, in the test, we tried to intercept the
goog.events.listen()call from the library code, to store away the 3rd argument, which is a callback when a certain XHR event is emitted. Once we have that callback stored away, we can call it at a right time in the test to simulate some new data coming in from the wire.The problem is that, in the
GrpcWebClientReadableStreamconstructor, there are two calls togoog.events.listen(). One forREADY_STATE_CHANGEand one forCOMPLETE. We want to intercept the first one but not the 2nd one.