Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-web interceptors implementation #785

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

stanley-cheung
Copy link
Collaborator

@stanley-cheung stanley-cheung commented Apr 20, 2020

This PR introduces interceptors for grpc-web according to the design we spec'ed out in #766

author:@Jennnnny

@stanley-cheung stanley-cheung force-pushed the interceptor-impl branch 3 times, most recently from a7765f6 to ecfd7c4 Compare April 24, 2020 03:15
@clehene
Copy link

clehene commented May 7, 2020

Just noted this was merged. That's really great!
I notice it's missing the actual documentation. How are users going to know about it and once they do know how to use it?

@stanley-cheung
Copy link
Collaborator Author

@clehene Yes good point. We have added an example using the interceptor here: https://github.com/grpc/grpc-web/blob/master/net/grpc/gateway/examples/echo/commonjs-example/client.js#L36. And we are working on a blog post. But to add to that, we probably should add something to our main README to point out some high level details about interceptors. Yes we should get to that in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants