Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata to error callback #671

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Add metadata to error callback #671

merged 2 commits into from
Oct 29, 2019

Conversation

stanley-cheung
Copy link
Collaborator

Roll forward of #667 after fixing JSDoc

@stanley-cheung
Copy link
Collaborator Author

@at-ishikawa FYI

@stanley-cheung stanley-cheung merged commit 3763612 into grpc:master Oct 29, 2019
@stanley-cheung stanley-cheung deleted the add-metadata-to-error branch October 29, 2019 17:52
@at-ishikawa
Copy link
Contributor

@stanley-cheung Sorry for missing this and thank you for fixing the issue.
The errors you shared in #670 are those when we run on browser, correct?
I think the reason why I didn't get is, I'd changed the compilation level of google closure compiler to SIMPLE and debugged it, but I'll try to reproduce it.

@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanley-cheung @at-ishikawa