-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match name nesting and imports in .d.ts with .js files #433
Match name nesting and imports in .d.ts with .js files #433
Conversation
@shaxbee Thanks for this contributions. Can you give us an example on what this achieves? Like maybe a couple of simple .protos and what the current and new behavior would be? Thanks |
@stanley-cheung Example generated code can be seen in shaxbee/grpc-web-dts-example Code generated using
Code generated using
My intent with this and future typings pull requests is to provide feature parity with ts-protoc-gen and eventually prepare pull request to protobuf, so typings for messages are generated in protoc-gen-js plugin :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions!
@stanley-cheung |
Exported names were incorrectly mangled and didn't reflect types in
* pb.js
files, resulting in runtime errors where trying to instantiate.Type aliases were replaced with proper nesting based on improbable-eng/ts-protoc-gen.
Aliased imports reflecting
*pb.js
files were added.Services now return correct message types for external protos.