Emit status event on empty stream response #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaxbee
force-pushed
the
empty-stream-status
branch
3 times, most recently
from
713ef5a
to
63414d2
Compare
stanley-cheung
requested changes
Dec 18, 2018
shaxbee
force-pushed
the
empty-stream-status
branch
from
63414d2
to
f2088d9
Compare
|
@stanley-cheung Done! :-) |
shaxbee
force-pushed
the
empty-stream-status
branch
2 times, most recently
from
476b52f
to
2f4051d
Compare
shaxbee
force-pushed
the
empty-stream-status
branch
from
2f4051d
to
25761e1
Compare
|
Fixed issues reported by kokoro. |
|
@shaxbee There seems to be still some error reported by Kokoro. Please take a look. Thanks! |
|
@stanley-cheung Sorry, missed that one :-) |
loyalpartner
pushed a commit
to loyalpartner/grpc-web
that referenced
this pull request
Sep 4, 2020
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 24.0.11 to 24.0.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stream is closed immediately by the server grpc-status and grpc-message headers are populated.
Current implementation is broken as it does not fire
statusorendevent in that case.