Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output dts about 'repeated' for --grpc-web_out=import_style=commonjs+dts #348

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

rybbchao
Copy link
Contributor

@rybbchao rybbchao commented Oct 31, 2018

if use "repeated" option in .proto, protoc will generate the method "get${PropertyName}List()" and
"set${PropertyName}List()" in .js
But .d.ts will output "get${PropertyName}()" and "set${PropertyName}()"

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the contribution! We should subsequently add a test for this though.

@stanley-cheung stanley-cheung merged commit 3ea2ea4 into grpc:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants