Add "strictDependencies" to suppress attribute of Bazel rule #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yannic this PR looks good. Can you rebase this? I also left some comments on the other outstanding PR, please take a look. Thanks for your contributions! |
Not suppressing this causes an error for a missing direct dependency for the generated gRPC-Web library if a service returns a protobuf message not declared in the same proto_library.
Yannic
force-pushed
the
suppress_strict_dependencies
branch
from
3b2b250
to
a1a7722
Compare
|
@stanley-cheung Thanks for your review(s)! Rebased #259 and #222, will fix the failing tests in #253 soon. |
stanley-cheung
approved these changes
Aug 30, 2018
loyalpartner
pushed a commit
to loyalpartner/grpc-web
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not suppressing this causes an error for a missing direct dependency
for the generated gRPC-Web library if a service returns a protobuf
message not declared in the same proto_library.