Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error code is a string instead of int #297

Closed
thesamet opened this issue Sep 24, 2018 · 1 comment · Fixed by #303
Closed

error code is a string instead of int #297

thesamet opened this issue Sep 24, 2018 · 1 comment · Fixed by #303

Comments

@thesamet
Copy link

When I set up envoy, but the upstream grpc server is not set up, the error code that is returned to the app is "14" as a string, instead of a number.

This line might be the culprit:

grpc-web/javascript/net/grpc/web/grpcwebclientreadablestream.js

Line 200 in 92aa9f8

code: responseHeaders[GRPC_STATUS],
- maybe the header needs to be converted to a number?
@stanley-cheung
Copy link
Collaborator

Acknowledged.

@stanley-cheung stanley-cheung mentioned this issue Oct 2, 2018
Merged
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this issue Sep 4, 2020
@jonny-improbable
Update all child packages to reference @improbable-eng/grpc-web (grpc…
0b66909 
…#297)

* Update all child packages to reference @improbable-eng/grpc-web

* Purge last references to grpc-web-client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error code should be number stanley-cheung/grpc-web
2 participants
@thesamet @stanley-cheung