Avoid a double-idle in the idle handler. #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The idle connectivity state can be achieved in two ways: 1. We have no active streams and receive a GOAWAY frame, and 2. We have no active streams and the idle timeout elapses. The only valid state we can be in to transition to idle is ready (i.e. we have an active channel and have received the first SETTINGS frame). We don't currently protect against going idle twice: that is, receiving a GOAWAY and subequently having the timeout fire. This leads to an invalid state transition (idle to idle). Modifications: - Check our 'readiness' state in the idle handler before calling 'idle()' on the connection manager - Add a test. - Alseo cancel the timeout when the handler is removed. Result: We avoid invalid state transitions when double-idling.
Closed
Lukasa
approved these changes
Jul 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The idle connectivity state can be achieved in two ways:
The only valid state we can be in to transition to idle is ready (i.e. we have
an active channel and have received the first SETTINGS frame). We don't
currently protect against going idle twice: that is, receiving a GOAWAY
and subequently having the timeout fire. This leads to an invalid state
transition (idle to idle).
Modifications:
'idle()' on the connection manager
Result:
We avoid invalid state transitions when double-idling.