Update CocoaPods for alpha13. #835
Conversation
|
@Jake-Prickett please hold off on doing the pod releases for now: I'm just updating NIOs |
scripts/build_podspecs.py
Outdated
| @@ -172,6 +173,8 @@ def get_grpc_deps(): | |||
| for obj in data['object']['pins']: | |||
| package = process_package(obj['package']) | |||
| version = obj['state']['version'] | |||
| # Strip the "patch" part of the version, as we want to allow users to use any patch version. | |||
| version = '.'.join(version.split('.')[0:2]) | |||
There was a problem hiding this comment.
Do you think we should actually just take the exact version as a minimum requirement and then bound the major version? It's a closer reflection of the Package.swift.
There was a problem hiding this comment.
The current code generates e.g. pod SwiftNIO, '~> 2.18', which according to my understanding should mean "any version of SwiftNIO >= 2.18 and < 3". Is that not what we want?
There was a problem hiding this comment.
We could depend on a non-zero patch version in Package.swift, which would be lost here. It's probably not an issue.
There was a problem hiding this comment.
Right, updated. @glbrntt PTAL
|
@Jake-Prickett first of all, sorry for all the requests today...! Unfortunately I have a few more... I've updated the NIO podspec scripts; when you get a chance could you release podspecs for:
I'll also tag an alpha-14 release of gRPC; could you then update the podspec for gRPC for alpha-14 once I've done that? |
|
I can do that today no problem! Thanks for doing that in the NIO repos! |
|
Awesome, thank you so much @Jake-Prickett! I've just submitted #838 to update the podspec (but not push them). I'll tag a release once that's been merged. Hopefully it should then just be over to you :D |
|
Okay, alpha-14 tagged, over to you @Jake-Prickett |
|
@glbrntt Pushed and good to go! 👍 |
|
Thanks again @Jake-Prickett! |
Also updates the script to run CocoaPods synchronously, and to allow users to use any patch version they please.
Not pushed to CocoaPods yet because of dependency mismatches.
@Jake-Prickett, please push the required dependencies (NIOSSL 2.7.4 in particular) and make sure that NIOSSL 2.7.4 depends on NIO 2.18. Afterwards, feel free to push gRPC alpha 13 as well or ping me to do it :-)
I also volunteer to be added as a maintainer for the NIO Pods, to let me take care of this myself the next time :-)