Add a retry limit to ConnectionBackoff #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
May 7, 2020
Sources/GRPC/ConnectionBackoff.swift
Outdated
| /// A limit on the number of times to attempt reconnection. | ||
| public var retries: Retries | ||
|
|
||
| public struct Retries { |
There was a problem hiding this comment.
Any reason not to just make this Hashable?
weissi
reviewed
May 7, 2020
Sources/GRPC/ConnectionBackoff.swift
Outdated
|
|
||
| /// A limited number of retry attempts. `limit` must be positive. Note that a limit of zero is | ||
| /// identical to `.none`. | ||
| public static func limited(to limit: Int) -> Retries { |
Lukasa
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
See #783
Modifications:
retriesoption toConnectionBackoffResult:
Connection attempts may now be made a limited number of times. By
default the behaviour is unchanged.
Resolves #783