-
Notifications
You must be signed in to change notification settings - Fork 428
Configure client connections with a builder #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,194 @@ | ||
/* | ||
* Copyright 2020, gRPC Authors All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import NIO | ||
import NIOSSL | ||
|
||
extension ClientConnection { | ||
/// Returns an insecure `ClientConnection` builder which is *not configured with TLS*. | ||
public static func insecure(group: EventLoopGroup) -> ClientConnection.Builder { | ||
return Builder(group: group) | ||
} | ||
|
||
/// Returns a `ClientConnection` builder configured with TLS. | ||
public static func secure(group: EventLoopGroup) -> ClientConnection.Builder.Secure { | ||
return Builder.Secure(group: group) | ||
} | ||
} | ||
|
||
extension ClientConnection { | ||
public class Builder { | ||
private let group: EventLoopGroup | ||
private var maybeTLS: ClientConnection.Configuration.TLS? { return nil } | ||
private var connectionBackoff = ConnectionBackoff() | ||
private var connectionBackoffIsEnabled = true | ||
private var errorDelegate: ClientErrorDelegate? | ||
private var connectivityStateDelegate: ConnectivityStateDelegate? | ||
|
||
fileprivate init(group: EventLoopGroup) { | ||
self.group = group | ||
} | ||
|
||
public func connect(host: String, port: Int) -> ClientConnection { | ||
let configuration = ClientConnection.Configuration( | ||
target: .hostAndPort(host, port), | ||
eventLoopGroup: self.group, | ||
errorDelegate: self.errorDelegate, | ||
connectivityStateDelegate: self.connectivityStateDelegate, | ||
tls: self.maybeTLS, | ||
connectionBackoff: self.connectionBackoffIsEnabled ? self.connectionBackoff : nil | ||
) | ||
return ClientConnection(configuration: configuration) | ||
} | ||
} | ||
} | ||
|
||
extension ClientConnection.Builder { | ||
public class Secure: ClientConnection.Builder { | ||
internal var tls = ClientConnection.Configuration.TLS() | ||
override internal var maybeTLS: ClientConnection.Configuration.TLS? { | ||
return self.tls | ||
} | ||
} | ||
} | ||
|
||
extension ClientConnection.Builder { | ||
/// Sets the initial connection backoff. That is, the initial time to wait before re-attempting to | ||
/// establish a connection. Jitter will *not* be applied to the initial backoff. Defaults to | ||
/// 1 second if not set. | ||
@discardableResult | ||
public func withConnectionBackoff(initial amount: TimeAmount) -> Self { | ||
self.connectionBackoff.initialBackoff = .seconds(from: amount) | ||
return self | ||
} | ||
|
||
/// Set the maximum connection backoff. That is, the maximum amount of time to wait before | ||
/// re-attempting to establish a connection. Note that this time amount represents the maximum | ||
/// backoff *before* jitter is applied. Defaults to 120 seconds if not set. | ||
@discardableResult | ||
public func withConnectionBackoff(maximum amount: TimeAmount) -> Self { | ||
self.connectionBackoff.maximumBackoff = .seconds(from: amount) | ||
return self | ||
} | ||
|
||
/// Backoff is 'jittered' to randomise the amount of time to wait before re-attempting to | ||
/// establish a connection. The jittered backoff will be no more than `jitter ⨯ unjitteredBackoff` | ||
/// from `unjitteredBackoff`. Defaults to 0.2 if not set. | ||
/// | ||
/// - Precondition: `0 <= jitter <= 1` | ||
@discardableResult | ||
public func withConnectionBackoff(jitter: Double) -> Self { | ||
self.connectionBackoff.jitter = jitter | ||
return self | ||
} | ||
|
||
/// The multiplier for scaling the unjittered backoff between attempts to establish a connection. | ||
/// Defaults to 1.6 if not set. | ||
@discardableResult | ||
public func withConnectionBackoff(multiplier: Double) -> Self { | ||
self.connectionBackoff.multiplier = multiplier | ||
return self | ||
} | ||
|
||
/// The minimum timeout to use when attempting to establishing a connection. The connection | ||
/// timeout for each attempt is the larger of the jittered backoff and the minimum connection | ||
/// timeout. Defaults to 20 seconds if not set. | ||
@discardableResult | ||
public func withConnectionTimeout(minimum amount: TimeAmount) -> Self { | ||
self.connectionBackoff.minimumConnectionTimeout = .seconds(from: amount) | ||
return self | ||
} | ||
|
||
/// Sets the initial and maximum backoff to given amount. Disables jitter and sets the backoff | ||
/// multiplier to 1.0. | ||
@discardableResult | ||
public func withConnectionBackoff(fixed amount: TimeAmount) -> Self { | ||
let seconds = Double.seconds(from: amount) | ||
self.connectionBackoff.initialBackoff = seconds | ||
self.connectionBackoff.maximumBackoff = seconds | ||
self.connectionBackoff.multiplier = 1.0 | ||
self.connectionBackoff.jitter = 0.0 | ||
return self | ||
} | ||
|
||
/// Sets whether the connection should be re-established automatically if it is dropped. Defaults | ||
/// to `true` if not set. | ||
@discardableResult | ||
public func withConnectionReestablishment(enabled: Bool) -> Self { | ||
self.connectionBackoffIsEnabled = enabled | ||
return self | ||
} | ||
} | ||
|
||
extension ClientConnection.Builder { | ||
/// Sets the client error delegate. | ||
@discardableResult | ||
public func withErrorDelegate(_ delegate: ClientErrorDelegate?) -> Self { | ||
self.errorDelegate = delegate | ||
return self | ||
} | ||
} | ||
|
||
extension ClientConnection.Builder { | ||
/// Sets the client connectivity state delegate. | ||
@discardableResult | ||
public func withConnectivityStateDelegate(_ delegate: ConnectivityStateDelegate?) -> Self { | ||
self.connectivityStateDelegate = delegate | ||
return self | ||
} | ||
} | ||
|
||
extension ClientConnection.Builder.Secure { | ||
/// Sets a server hostname override to be used for the TLS Server Name Indication (SNI) extension. | ||
/// The hostname from `connect(host:port)` is for TLS SNI if this value is not set and hostname | ||
/// verification is enabled. | ||
@discardableResult | ||
public func withTLS(serverHostnameOverride: String?) -> Self { | ||
self.tls.hostnameOverride = serverHostnameOverride | ||
return self | ||
} | ||
|
||
/// Sets the sources of certificates to offer during negotiation. No certificates are offered | ||
/// during negotiation by default. | ||
@discardableResult | ||
public func withTLS(certificateChain: [NIOSSLCertificate]) -> Self { | ||
// `.certificate` is the only non-deprecated case in `NIOSSLCertificateSource` | ||
self.tls.certificateChain = certificateChain.map { .certificate($0) } | ||
return self | ||
} | ||
|
||
/// Sets the private key associated with the leaf certificate. | ||
@discardableResult | ||
public func withTLS(privateKey: NIOSSLPrivateKey) -> Self { | ||
// `.privateKey` is the only non-deprecated case in `NIOSSLPrivateKeySource` | ||
self.tls.privateKey = .privateKey(privateKey) | ||
return self | ||
} | ||
|
||
/// Sets the trust roots to use to validate certificates. This only needs to be provided if you | ||
/// intend to validate certificates. Defaults to the system provided trust store (`.default`) if | ||
/// not set. | ||
@discardableResult | ||
public func withTLS(trustRoots: NIOSSLTrustRoots) -> Self { | ||
self.tls.trustRoots = trustRoots | ||
return self | ||
} | ||
} | ||
|
||
fileprivate extension Double { | ||
static func seconds(from amount: TimeAmount) -> Double { | ||
return Double(amount.nanoseconds) / 1_000_000_000 | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still alpha right? You could make an API-breaking change to hide these initialisers and force people to use the new
secure
andinsecure
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right but it's impossible to provide fix-its for this and it's quite an annoying change to have to make. I'm leaning towards keeping it for now. The longer term plan would be to not add anything to it to gently force people to the builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not hide this initialiser, as this would disallow precise configuration by hands, which is often needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@be4rd what's your use case here? Everything should be representable by the builder as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glbrntt if you'd like to keep it another option to dissuade use would be to deprecate or provide a warning for direct use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glbrntt sorry, did not saw TLS configuration methods in builder when I left a comment 😅