Remove fix-project-settings.rb references from Makefile #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #693 |
MrMage
approved these changes
Jan 13, 2020
|
It was removed with all the other stale documentation/examples etc. To be honest, I removed it without thinking. Happy to put it back though if you think? |
|
Hmm. It can help with some people sending wrongly-formatted PRs, for example. Our indentation settings are fairly non-standard. I would suggest re-adding it. |
Motivation: The fix-project-settings.rb script was prematurely removed. Modifications: Add it back. Result: Happier .xcodeproj generation.
glbrntt
force-pushed
the
gb-remove-fix-project-settings
branch
from
43a91fd to
2ad194e
Compare
|
Re-added but to |
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Jan 24, 2020
Motivation: The fix-project-settings.rb script was prematurely removed. Modifications: Add it back. Result: Happier .xcodeproj generation.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The Makefile referenced a file which no longer exists.
Modifications:
Remove references to that file.
Result:
More happy project generation.