Remove v2 code from v1 #2110
Merged
Remove v2 code from v1 #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There's a bug in SwiftPM which prohibits the Xcode build system from being used if a dependency explicitly declares which Swift language mode is being used, regardless of its value. A number of users are running into this problem, and while it's not a gRPC Swift bug we can work around the issue by removing the v2 code from the v1 branch and removing the Swift 6 specific manifest. Modifications: - Remove all v2 code - Remove workarounds in the SwiftPM build plugin which avoid deprecation warnings. It turns out that the guard was incorrect anyway: the API isn't guarded by the compiler version, but the package tools version. Result: Possible to build v1 with SwiftPM using the Xcode build system.
rnro
approved these changes
Nov 8, 2024
|
I did look over all the modified files and the classes of deleted files and it all looks sensible to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There's a bug in SwiftPM which prohibits the Xcode build system from being used if a dependency explicitly declares which Swift language mode is being used, regardless of its value. A number of users are running into this problem, and while it's not a gRPC Swift bug we can work around the issue by removing the v2 code from the v1 branch and removing the Swift 6 specific manifest.
Modifications:
Result:
Possible to build v1 with SwiftPM using the Xcode build system.