-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all_extension_numbers_of_type reflection requests #1680
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b618a11
first changes for all extensions numbers
stefanadranca a0c3f65
added changes from all-extension-numbers branch
stefanadranca dfd4fcb
Implemented the all_extension_numbers_of_type request for the Reflect…
stefanadranca f5e38e4
extendee name is now the fully qualified name of the type, prefixed w…
stefanadranca e398aa3
formatted
stefanadranca c5042f0
implemented feedback
stefanadranca abfffd6
Merge branch 'main' into sd-reflection-service
stefanadranca d5027ed
changed the extensionsFieldNumbersOfType API
stefanadranca 9537ac6
removed the messegeTypeArray
stefanadranca 819735a
small fix
stefanadranca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behaviour is surprising:
nil
usually means the thing we were looking for didn't exist (e.g. considerdictionary["foo"]
). Having it also returnnil
when the type exists but doesn't have any extensions isn't a good API because it places the onus on the caller to work out whether the type exists or not.In this case we should probably just do the work upfront and ensure that
fieldNumbersByType
contains the right information, i.e. empty arrays when the type exists but has no extensions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not right: the only reason we store
messageTypeNames
is to check whether a message exists in this function, it isn't used anywhere else.When we create and populate
fieldNumbersByType
we should do so such it has a value for every type we know about, even if the value is an empty array. It means we do the work upfront and the semantics are clear: if a value exists then the type exists, if no value exists then we don't know about the type.