Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package visibility modifier #1674

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add package visibility modifier #1674

merged 1 commit into from
Oct 16, 2023

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Oct 16, 2023

Motivation

We want to allow the new package visibility modifier to be used when generating code.

Modifications

Add a new package Visibility modifier case to both the SPM and protoc plugins.

Result

Code can now be generated with package visibility, and not just internal or public.

@gjcairo gjcairo requested a review from glbrntt October 16, 2023 13:02
@gjcairo gjcairo marked this pull request as ready for review October 16, 2023 13:02
glbrntt
glbrntt approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks Gus!

@glbrntt glbrntt added the semver/patch No public API change. label Oct 16, 2023
@glbrntt glbrntt merged commit 5e8afe9 into grpc:main Oct 16, 2023
14 checks passed
@gjcairo gjcairo deleted the package-modifier branch March 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjcairo @glbrntt