Skip to content

Bump minimum protobuf version to 1.19.0 #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Mar 28, 2022

Motivation:

swift-protobuf added Sendable conformance to generated messages in
the 1.19.0 release.

Modifications:

  • Bump minimum protobuf version
  • Regenerate examples and interop tests

Result:

Protobuf messages are Sendable

Motivation:

swift-protobuf added `Sendable` conformance to generated messages in
the 1.19.0 release.

Modifications:

- Bump minimum protobuf version
- Regenerate examples and interop tests

Result:

Protobuf messages are `Sendable`
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Mar 28, 2022
@glbrntt glbrntt requested a review from fabianfett March 28, 2022 15:20
@glbrntt
Copy link
Collaborator Author

glbrntt commented Mar 28, 2022

Allocation limits are off: fixed in #1377

Copy link
Collaborator

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glbrntt glbrntt merged commit e933e79 into grpc:1.7.1-async-await Mar 29, 2022
@glbrntt glbrntt deleted the gb-update-protobuf branch March 29, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants