Add support for NIOCertificateReloading #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: swift-nio-extras recently added support for certificate reloaders which can keep cert chain and private keys up-to-date in the background and provide current values when asked for them. We should expose an API allowing these to be configured. Modifications: - Expose API on the TLS configs for posix-based transports to create the TLS config using a cert reloader Result: Users can create TLS configs using the new cert relader
rnro
reviewed
May 20, 2025
rnro
reviewed
May 20, 2025
gjcairo
approved these changes
May 20, 2025
Co-authored-by: Rick Newton-Rogers <rnro@apple.com>
rnro
approved these changes
May 20, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
May 30, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `gRPC Swift NIO Transport` to 1.2.2 from 1.1.0. ### Why are the changes needed? This brings the following improvements and bug fixes. Previously, 1.2.0 and 1.2.1 causes a crash in GitHub Action CI. - https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.2.2 - grpc/grpc-swift-nio-transport#110 - https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.2.1 - https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.2.0 - grpc/grpc-swift-nio-transport#101 - grpc/grpc-swift-nio-transport#103 - grpc/grpc-swift-nio-transport#104 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #185 from dongjoon-hyun/SPARK-52359. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-nio-extras recently added support for certificate reloaders which can keep cert chain and private keys up-to-date in the background and provide current values when asked for them. We should expose an API allowing these to be configured.
Modifications:
Result:
Users can create TLS configs using the new cert relader