Make PeerAddress/init faster
#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Feb 12, 2025
Sources/GRPCOTelTracingInterceptors/Tracing/SpanAttributes+GRPCTracingKeys.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCOTelTracingInterceptors/Tracing/SpanAttributes+GRPCTracingKeys.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCOTelTracingInterceptors/Tracing/SpanAttributes+GRPCTracingKeys.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCOTelTracingInterceptors/Tracing/SpanAttributes+GRPCTracingKeys.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCOTelTracingInterceptors/Tracing/SpanAttributes+GRPCTracingKeys.swift
Outdated
Show resolved
Hide resolved
Comment on lines
205
to
208
| guard elementValue >= 0, elementValue <= 9 else { | ||
| // non-digit character | ||
| return nil | ||
| } |
There was a problem hiding this comment.
At the moment if utf8Element is e.g. 47 then we'll underflow and crash when creating elementValue.
We should validate the UInt8 value and then do the conversion. It also means that the subtraction in the conversion can be unchecked.
There was a problem hiding this comment.
I thought maybe using a range instead was clearer so I've done, but I'm actually unsure if the range allocates or if it's all nicely optimised by the compiler.
glbrntt
approved these changes
Feb 13, 2025
| value &+= Int(utf8Char) | ||
| } | ||
|
|
||
| guard value <= 65535 else { |
There was a problem hiding this comment.
nit: let the compiler do the maths
Suggested change
| guard value <= 65535 else { | |
| guard value <= Int(UInt16.max) else { |
glbrntt
approved these changes
Feb 14, 2025
glbrntt
requested changes
Feb 14, 2025
Sources/GRPCOTelTracingInterceptors/Tracing/SpanAttributes+GRPCTracingKeys.swift
Outdated
Show resolved
Hide resolved
glbrntt
approved these changes
Feb 14, 2025
| // non-digit character | ||
| return nil | ||
| } | ||
| value &+= Int(utf8Char - UInt8(ascii: "0")) |
There was a problem hiding this comment.
we can do unchecked here because we checked the range of values above
Suggested change
| value &+= Int(utf8Char - UInt8(ascii: "0")) | |
| value &+= Int(utf8Char &- UInt8(ascii: "0")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeerAddress/initcurrently usesStringandsplits them, which is not very optimal. This PR uses UTF8View instead to avoid allocations/make things faster