Rename interceptors module #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is a module name change a breaking change? Not sure. |
gjcairo
force-pushed
the
rename-interceptors
branch
from
facc0c8 to
027920e
Compare
glbrntt
requested changes
Jan 24, 2025
Yup, if you depended on the module before your build will break because the module no longer exists! |
|
I think you'll need to update |
gjcairo
force-pushed
the
rename-interceptors
branch
from
2f4a213 to
f941b31
Compare
glbrntt
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
GRPCInterceptorsmodule toGRPCOTelTracingInterceptor.