Conform server tracing interceptor to OTel's conventions #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
otel-server-interceptor
branch
from
beb8738 to
8c7c470
Compare
|
Expected, as the interceptor's been renamed: |
gjcairo
force-pushed
the
otel-server-interceptor
branch
from
8c7c470 to
a377c43
Compare
gjcairo
force-pushed
the
otel-server-interceptor
branch
from
a377c43 to
b697ad5
Compare
glbrntt
approved these changes
Jan 24, 2025
Sources/GRPCInterceptors/Tracing/ServerOTelTracingInterceptor.swift
Outdated
Show resolved
Hide resolved
…swift Co-authored-by: George Barnett <gbarnett@apple.com>
|
Thanks @glbrntt - you'll have to merge it yourself as there's an (expected) API break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the same changes made to the client in #25 to the server interceptor, conforming it to follow recommendations/conventions laid out in both: