Remove unused grpc-swift v1 reflection code #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The reflection code is for v1 and not reference by any target yet. It needs to be brought up-to-date for v2. Given we need to make a few changes along the way the diff will be clearer if done from scratch rather than as a large diff on v1. Modifications: - Remove v1 reflection code Result: Nothing
gjcairo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The reflection code is for v1 and not reference by any target yet. It needs to be brought up-to-date for v2. Given we need to make a few changes along the way the diff will be clearer if done from scratch rather than as a large diff on v1.
Modifications:
Result:
Nothing